Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some manifest decode Error. #2122

Merged
merged 3 commits into from
Mar 16, 2024
Merged

fix some manifest decode Error. #2122

merged 3 commits into from
Mar 16, 2024

Conversation

CKCat
Copy link
Contributor

@CKCat CKCat commented Mar 11, 2024

  1. The elementSize may be larger than the actual size of the element chunk.
  2. End namespace chunk size can be any value. also fix issue [core]Error decode manifest #1232 .

AndroidManifest.zip

issue #1232 APK file.
com.vmos.pro.apk.zip

@skylot
Copy link
Owner

skylot commented Mar 16, 2024

@CKCat thanks, looks good 👍
Although, I am not sure if we correctly handle chunk data size in parseNameSpaceEnd() now, maybe we should make a more common code to skip trailing bytes, but is definitely for another commit/PR 🙂

@skylot skylot merged commit eecdfae into skylot:master Mar 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants