Implemented cache only mode and updated unit tests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->log->debug("Refresh forced, skipping cached content from $filePath"); | ||
| if ($cacheOnly == true) { | ||
| unset($urls); | ||
| $urls[]=$filePath; |
There was a problem hiding this comment.
use $urls = array($filePath) instead of unsetting it first and recreating the var
Closed
|
Implemented suggested fixes |
| } | ||
| } else { | ||
| if ($cacheOnly) { | ||
| throw new SyncException("No cache file found",array("No cache file found in cache only mode")); |
There was a problem hiding this comment.
It's ok to just return array() here, the public API calling prepareUrls already throws an exception
|
Can you do a rebase -i to squash your commits then I'll pull it in and do some cleanups. |
|
branche rebased and implemented suggested change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.