Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERVE] Add headers to the readiness probe #3616

Closed
JGSweets opened this issue May 30, 2024 · 2 comments
Closed

[SERVE] Add headers to the readiness probe #3616

JGSweets opened this issue May 30, 2024 · 2 comments

Comments

@JGSweets
Copy link
Contributor

If the serve function deploys a feature which utilizes authentication via headers, the readiness probe cannot interact with it.

Solution:

  • update schema for readiness_probe to include a headers dictionary
  • update sky/serve/replica_managers.py::ReplicaInfo to utilize headers when making the request.
  • (optional) allow the schema to utilize the envs section to utilize values in the service
@Michaelvll
Copy link
Collaborator

Michaelvll commented May 30, 2024

This should be added in #3552, and we are adding the doc for it #3587. Would you like to have a try for SkyPilot’s nightly build with pip uninstall skypilot; pip install -U skypilot-nightly

envs:
  AUTH_TOKEN: # left empty as a required filled during launch
services:
  readiness_probe:
    path: /v1/models
    # Set authorization headers here if needed.
    headers:
      Authorization: Bearer $AUTH_TOKEN

@JGSweets
Copy link
Contributor Author

Wicked! I missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants