Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docker] --runtime nvidia vs --gpus all #3834

Closed
Michaelvll opened this issue Aug 15, 2024 · 1 comment
Closed

[Docker] --runtime nvidia vs --gpus all #3834

Michaelvll opened this issue Aug 15, 2024 · 1 comment
Labels
good first issue Good for newcomers good starter issues

Comments

@Michaelvll
Copy link
Collaborator

We currently add --runtime nvidia automatically in our docker_utils when a GPU is available on a cluster. However, this option is deprecated to --gpus all. We may need to double check if we can completely switch to --gpus all instead.

https://github.com/skypilot-org/skypilot/blob/master/sky/provision/docker_utils.py#L384

We can check if ray's node providers changed that option as a reference.
@Michaelvll
Copy link
Collaborator Author

Fixed in #3833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers good starter issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Michaelvll