-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork sky.execute when stream_logs=False #59
Comments
I agree that if we are not planning to print anything anymore, we should return the shell to the user. But then we'd need something like |
Yep, this is something that will be added to CLI.
Gautam
…On Wed, Nov 24 2021 at 11:00 AM, Frank Luan ***@***.***> wrote:
I agree that if we are not planning to print anything anymore, we should
return the shell to the user. But then we'd need something like sky ps to
monitor the progress, running jobs, etc.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPL7FQQTLJ2Q4TH7O4TVW3UNUY4TANCNFSM5IVPPIHA>
.
|
in this case, we'll be also needing CLI to kill a given sky task. |
This is subsumed by #134: Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Mainly looking at this from a UX perspective, but if you turn
stream_logs=False
(only pipe output to file, not stdout) you get this awkward interaction where sky execute still has control of the main terminal and it looks like it's just hanging while all the output goes to a logfile. Instead, we should run the process in the background and return control to the user's shell session so they can do other things (e.g. tail the logfile, launch another run, launch a gpunode, write code, etc.).The text was updated successfully, but these errors were encountered: