Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork sky.execute when stream_logs=False #59

Closed
gmittal opened this issue Nov 24, 2021 · 4 comments
Closed

Fork sky.execute when stream_logs=False #59

gmittal opened this issue Nov 24, 2021 · 4 comments

Comments

@gmittal
Copy link
Collaborator

gmittal commented Nov 24, 2021

Mainly looking at this from a UX perspective, but if you turn stream_logs=False (only pipe output to file, not stdout) you get this awkward interaction where sky execute still has control of the main terminal and it looks like it's just hanging while all the output goes to a logfile. Instead, we should run the process in the background and return control to the user's shell session so they can do other things (e.g. tail the logfile, launch another run, launch a gpunode, write code, etc.).

@franklsf95
Copy link
Contributor

I agree that if we are not planning to print anything anymore, we should return the shell to the user. But then we'd need something like sky ps to monitor the progress, running jobs, etc.

@gmittal
Copy link
Collaborator Author

gmittal commented Nov 24, 2021 via email

@infwinston
Copy link
Member

in this case, we'll be also needing CLI to kill a given sky task.

@concretevitamin
Copy link
Collaborator

This is subsumed by #134: Use -d for sky run/exec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants