Scrambled spaces in logging

[Michaelvll]

There's also a situation where @infwinston and I saw - sometimes after Ctrl-C, or after tailing the log, the lines contain scrambled spaces (like we saw before) or the shell's cursor disappears. Did you see that issue?

Originally posted by @concretevitamin in #69 (comment)

[Michaelvll]

@michaelzhiluo Hi Michael, could you please describe the issue you observed? Is it during provision or executing the tasks? Is it happening for the multiple tasks scenario (for this one, we may need to set stream_logs to false to avoid multiple tasks shooting the outputs to the console simultaneously)? Thanks!

[Michaelvll]

I found a problem with the Ctrl-C. When the provision/task is running and printing out the results, sometimes, Ctrl-C does not work. We may need to capture the KeyboardInterrupt exception while redirecting the output.

[michaelzhiluo]

@Michaelvll Sorry just saw this! I am not observing this issue anymore (somehow it fixed itself)

[Michaelvll]

There's also a situation where @infwinston and I saw - sometimes after Ctrl-C, or after tailing the log, the lines contain scrambled spaces (like we saw before) or the shell's cursor disappears. Did you see that issue?

Originally posted by @concretevitamin in #69 (comment)

I reproduced the error. After tail -f <sky_logs> when there is a progress bar 'progressing' and Ctrl-C, the cursor will disappear.

Current TODOs:

• Fix cursor missing problem (Reason: sometimes the loggs will output "\x1b[?25l"], which will hide the cursor)
• Fix Ctrl-C not responding problem

[concretevitamin]

Wow this is a really good find!

…

On Fri, Dec 3, 2021 at 4:56 AM Zhanghao Wu ***@***.***> wrote: There's also a situation where @infwinston <https://github.com/infwinston> and I saw - sometimes after Ctrl-C, or after tailing the log, the lines contain scrambled spaces (like we saw before) or the shell's cursor disappears. Did you see that issue? *Originally posted by @concretevitamin <https://github.com/concretevitamin> in #69 (comment) <#69 (comment) I reproduced the error. After tail -f <sky_logs> when there is a progress bar 'progressing' and Ctrl-C, the cursor will disappear. It may be due to the \r produced by the progress bar. Current TODOs: - Fix cursor missing problem - Fix Ctrl-C not responding problem — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#72 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEQWHRMJSDKB3YYFDEVODLUO7MQZANCNFSM5JANYQ4Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Michaelvll]

Fixed in #82. Please feel free to open a new issue if you find any problem.