Add sky tpunode
#120
Merged
Add sky tpunode
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelzhiluo
previously requested changes
Dec 23, 2021
romilbhardwaj
approved these changes
Dec 23, 2021
Comment on lines
+573
to
+590
| @click.option('--cluster', | ||
| '-c', | ||
| default=None, | ||
| type=str, | ||
| help=_CLUSTER_FLAG_HELP) | ||
| @click.option('--port-forward', | ||
| '-p', | ||
| multiple=True, | ||
| default=[], | ||
| type=int, | ||
| required=False, | ||
| help=('Port to be forwarded. To forward multiple ports, ' | ||
| 'use this option multiple times.')) | ||
| @click.option('--screen', | ||
| default=False, | ||
| is_flag=True, | ||
| help='If true, attach using screen.') | ||
| def tpunode(cluster: str, port_forward: Optional[List[int]], screen): |
There was a problem hiding this comment.
Possible future refactor, not necessary:
There seems to be considerable overlap between gpunode, cpunode and tpunode (similar click.options, docs, args and body). Maybe there's some opportunity for refactoring here
There was a problem hiding this comment.
Great suggestion. Made a note in #122.
michaelzhiluo
approved these changes
Dec 23, 2021
|
I tested this and filed #129. |
gmittal
added a commit
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TPU nodes in addition to GPU/CPU nodes! Verified that
sky tpunodeexhibits same functionality as cpunode/gpunode and that the TPU is actually attached to the created cluster usingcapture_tpu_profile --tpu=$TPU_NAME --monitoring_level=2.