GCP/Azure: add skypilot-user tags to VMs on these clouds.
#1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
LGTM. I actually experienced the difficulties in identifying the owner of the VMs in our GCP and Azure accounts. The new update would be really helpful. Thanks for adding this @concretevitamin!
| # A basic check. Programmatic calls will have a proper (but less | ||
| # informative) error from optimizer. | ||
| if (cloud is not None and cloud.lower() == 'azure' and | ||
| use_spot is not None and use_spot): |
There was a problem hiding this comment.
Can't it be shortened as use_spot?
There was a problem hiding this comment.
Good question. This is religiously following the styleguide where we explicitly test None rather than implicitly.
|
Thanks @WoosukKwon. Merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better accountability.
Tested (run the relevant ones):
GCP head + worker (note: they have "labels" and "tags"; former is used):
Azure head + worker:
Also tested (previously was throwing an error from within optimizer,
No resource satisfying None on Azure):