Add GCP permission check #1772
Merged
Add GCP permission check #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Thanks for adding the check @infwinston! That can significantly improve the UX for initial GCP users.
sky/clouds/gcp.py
Outdated
Comment on lines
553
to
556
| 'You do not have below required permissions to access ' | ||
| 'the project.\n ' | ||
| f'{diffs}\n ' | ||
| 'Visit https://skypilot.readthedocs.io/en/latest/reference/faq.html#what-are-the-required-iam-permissons-on-gcp-for-skypilot for details.') # pylint: disable=line-too-long |
There was a problem hiding this comment.
Suggested change
| 'You do not have below required permissions to access ' | |
| 'the project.\n ' | |
| f'{diffs}\n ' | |
| 'Visit https://skypilot.readthedocs.io/en/latest/reference/faq.html#what-are-the-required-iam-permissons-on-gcp-for-skypilot for details.') # pylint: disable=line-too-long | |
| 'The following permissions are not enabled for the current GCP ' | |
| f'identity {identity}.\n' | |
| f'{diffs}\n ' | |
| 'For more details, visit: https://skypilot.readthedocs.io/en/latest/reference/faq.html#what-are-the-required-iam-permissons-on-gcp-for-skypilot') # pylint: disable=line-too-long |
The identity can be got from the return value of L468.
sumanthgenz
pushed a commit
to sumanthgenz/skypilot
that referenced
this pull request
Mar 16, 2023
* Add GCP permission check * add one perm * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #1755 by adding permission checking for GCP.
Tested (run the relevant ones):
sky check.