Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1.1.1.1 instead of 8.8.8.8 as IP for network check. #1800

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

concretevitamin
Copy link
Collaborator

We've seen reports that 8.8.8.8 can be unreachable (#1767).

Changes to Cloudflare's 1.1.1.1 as a mitigation.

Tested (run the relevant ones):

  • Any manual or new tests for this PR (please specify below)
  • (US) sky launch --cloud gcp --down
  • Confirmed with friend in China that 1.1.1.1 is reachable

Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

BTW perhaps we should add redundancy in our network checks ("try 8.8.8.8 or 1.1.1.1, if either works == all good"). Feel free to file an issue for that to fix later.

@concretevitamin
Copy link
Collaborator Author

BTW perhaps we should add redundancy in our network checks ("try 8.8.8.8 or 1.1.1.1, if either works == all good"). Feel free to file an issue for that to fix later.

Yeah. Also, thinking we should get rid of this network check in the future if possible (to guard against whatever IP we use being blocked somewhere, or the IP changes, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants