-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality to support specifying quantity of a resource in call to show-gpus #1924
Added functionality to support specifying quantity of a resource in call to show-gpus #1924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Saikrishna-Achalla! This is a great first step to implementing this feature. Left some comments.
I got a runaway Resource 'V100' with quantity 4 not found. Try 'sky show-gpus --all' to show available accelerators and their quantities.
when I ran the command below. Is this expected?
(base) ➜ ~ sky show-gpus V100:4
*NOTE*: for most GCP accelerators, INSTANCE_TYPE == (attachable) means the host VM's cost is not included.
GPU QTY CLOUD INSTANCE_TYPE DEVICE_MEM vCPUs HOST_MEM HOURLY_PRICE HOURLY_SPOT_PRICE REGION
V100 4 AWS p3.8xlarge 16GB 32 244GB $ 12.240 $ 3.672 ap-northeast-1
V100 4 Azure Standard_NC24rs_v3 - 24 448GB $ 13.460 $ 4.506 centralus
V100 4 Azure Standard_NC24s_v3 - 24 448GB $ 12.240 $ 4.097 centralus
V100 4 GCP (attachable) - - - $ 9.920 $ 2.960 us-central1 Resource 'V100' with quantity 4 not found. Try 'sky show-gpus --all' to show available accelerators and their quantities.
…e if request is not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Saikrishna-Achalla! Left some comments.
…nnecessary filtering logic. Tested and code works with multiple inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Saikrishna-Achalla! Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final nit, otherwise good to go! Thanks for this contribution @Saikrishna-Achalla! 🚀
This PR fixes issue #1915. Previously, users were not able to specify the GPU quantity that they wanted. This PR allows users to do so by running sky show-gpus V100:4 to find the cloud providers and regions that offer 4 V100 GPUs.
The output is now as follows:
Failure output is as follows:
Tested (run the relevant ones):
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh