Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency] Drop Python 3.6 support, switch to Python>=3.7 and fix azure launching issue #1952

Merged
merged 4 commits into from
May 12, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 12, 2023

Our previous patch for the azure-identity is outdated and causing trouble launching azure cluster. Since the latest azure-identity contains the process_timeout argument, we can directly use that to solve the problem we mentioned in

# Fix the Azure get-access-token (used by ray azure node_provider) timeout issue,
# by increasing the timeout.
# Tracked in https://github.com/Azure/azure-cli/issues/20404#issuecomment-1249575110
# Only patch it if azure cli is installed.

Also, closes #609

Based on #1954

Tested (run the relevant ones):

  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test-azure --cloud azure --cpus 4+
    • sky launch -c test-azure-2 --cloud azure --cpus 4+ --num-nodes 2
  • All smoke tests: pytest tests/test_smoke.py
  • All smoke tests: pytest tests/test_smoke.py --aws

@Michaelvll Michaelvll changed the title [Azure] Fix azure cli version mismatch [Dependency] Upgrade python version and fix azure cli version mismatch May 12, 2023
Copy link
Collaborator

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll. Tested launching on a previously stopped GCP cluster.

Before merging, can we update the ">= 3.6" note in the following places?

» ag '>= 3.6'
sky/design_docs/onprem-design.md
13:- Python >= 3.6 for all users.

docs/source/getting-started/installation.rst
8:  $ # SkyPilot requires python >= 3.6. For Apple Silicon, use >= 3.8.

docs/source/reference/local/setup.rst
25:   $ # SkyPilot requires python >= 3.6.

CONTRIBUTING.md
19:# SkyPilot requires python >= 3.6.

Some of these duplicate notes probably can be dropped.

@concretevitamin
Copy link
Collaborator

Nit: maybe change title to be something like "Drop Python 3.6 requirement and allow >= 3.7 ...", just to ease future release notes writing.

@Michaelvll Michaelvll changed the title [Dependency] Upgrade python version and fix azure cli version mismatch [Dependency] Drop Python 3.6 support and fix azure cli version mismatch issue May 12, 2023
@Michaelvll Michaelvll changed the title [Dependency] Drop Python 3.6 support and fix azure cli version mismatch issue [Dependency] Drop Python 3.6 support, switch to Python>=3.7 and fix azure launching issue May 12, 2023
@Michaelvll Michaelvll merged commit 47336da into master May 12, 2023
15 checks passed
@Michaelvll Michaelvll deleted the fix-azure-cli branch May 12, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade python requirement to python>=3.7
2 participants