[UX] Print useful message when image id not found #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @cblmemo. Minor UX nits. I guess it's fine to leave docker:xxx to the future?
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
concretevitamin
approved these changes
Sep 28, 2023
| @@ -83,15 +84,18 @@ | |||
| # TODO(zhwu): Move the default AMI size to the catalog instead. | |||
| DEFAULT_GCP_IMAGE_GB = 50 | |||
|
|
|||
| USER_PORTS_FIREWALL_RULE_NAME = 'sky-ports-{}' | |||
There was a problem hiding this comment.
Short comment? Add a blank line to separate it from L88
There was a problem hiding this comment.
Sorry wdym by 'short comment'? Did you mean to short the following string so we could get rid of the # pylint: disable=line-too-long?
There was a problem hiding this comment.
# Describe this var briefly.
USER_PORTS_FIREWALL_RULE_NAME = 'sky-ports-{}'
:)
jc9123
pushed a commit
to jc9123/skypilot
that referenced
this pull request
Oct 11, 2023
* add aws, gcp * fix * fix * add IBM message * Update sky/clouds/gcp.py Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update sky/clouds/aws.py Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * apply suggestion from code review * add newline * add blank line * add comments for constants --------- Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2519 by adding some messages to help the user debug. Most of the messages are pasted from our
yaml-spec.rst.Current docker implementation won't check whether the docker image exists, so no message for docker is added in this PR.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh