Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog] Fix aws catalog fetcher for removed offerings #2610

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Sep 26, 2023

The g2.8xlarge has been removed from the list of offerings on eu-west-1, which causes the recent failure of catalog fetcher. We now avoid the spot pricing table introducing nan rows.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • python -m sky.clouds.service_catalog.data_fetchers.fetch_aws
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one nit ;)

sky/clouds/service_catalog/data_fetchers/fetch_aws.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 8184f2a into master Sep 27, 2023
18 checks passed
@Michaelvll Michaelvll deleted the fix-aws-fetch-for-removed-offerings branch September 27, 2023 01:39
jc9123 pushed a commit to jc9123/skypilot that referenced this pull request Oct 11, 2023
…#2610)

* Fix aws catalog fetcher for removed offerings

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants