UX: Fix spot launch hint. #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
approved these changes
Sep 30, 2023
| @@ -772,8 +772,7 @@ def format_number(x): | |||
|
|
|||
| num_tasks = len(ordered_node_to_cost_map) | |||
| for task, v in ordered_node_to_cost_map.items(): | |||
| task_str = (f'for task_lib.Task {repr(task)!r}' | |||
| if num_tasks > 1 else '') | |||
| task_str = (f'for task {repr(task)!r} ' if num_tasks > 1 else '') | |||
There was a problem hiding this comment.
Suggested change
| task_str = (f'for task {repr(task)!r} ' if num_tasks > 1 else '') | |
| task_str = (f'for task {repr(task)!r}' if num_tasks > 1 else '') |
nit: seems like there is an extra space?
There was a problem hiding this comment.
Previous to this change, it looks like
…Task ‘train’(1 node)
Closed
5 tasks
jc9123
pushed a commit
to jc9123/skypilot
that referenced
this pull request
Oct 11, 2023
* UX: Fix spot launch hint. * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2591. This is an alternative that hopefully is clearer.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh