Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nits #2633

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix nits #2633

merged 2 commits into from
Oct 2, 2023

Conversation

suquark
Copy link
Collaborator

@suquark suquark commented Oct 1, 2023

Fix some typos.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Michaelvll
Michaelvll approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @suquark! LGTM

@suquark suquark merged commit 0bbefeb into master Oct 2, 2023
18 checks passed
@suquark suquark deleted the fix_nits branch October 2, 2023 18:04
jc9123 pushed a commit to jc9123/skypilot that referenced this pull request Oct 11, 2023
@suquark @jc9123
Fix nits (skypilot-org#2633)
202e663 
* fix nits

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suquark @Michaelvll