feat(update): Adding CoreWeave label to identify GPUs in K8s #2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romilbhardwaj
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Awesome, thanks @rtalaricw and welcome to SkyPilot! Super excited to have coreweave support. One minor comment, otherwise LGTM.
sky/utils/kubernetes_utils.py
Outdated
| @@ -304,6 +327,7 @@ def get_gpu_label_key_value(acc_type: str, check_mode=False) -> Tuple[str, str]: | |||
| # Check if the cluster has GPU labels setup correctly | |||
| label_formatter, node_labels = \ | |||
| detect_gpu_label_formatter() | |||
|
|
|||
There was a problem hiding this comment.
Are these new lines at L330 and L354 unintended? If so, can we revert them?
jc9123
pushed a commit
to jc9123/skypilot
that referenced
this pull request
Oct 11, 2023
…org#2650) * feat(update): Adding CoreWeave label to identify GPUs in K8s * feat(fix): Remove broken line * feat(fix): Fixing label_formatter detection * feat(code): Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
CoreWeaveLabelFormatterto identify GPU nodes within our K8s cluster.format.sh.