[k8s] Add label validation during sky check
#2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o k8s_gpulabel_validation # Conflicts: # sky/utils/kubernetes_utils.py # tests/test_optimizer_dryruns.py
landscapepainter
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
@romilbhardwaj Tested out and it works as expected. Left some minor comments. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2652. Adds a
validate_label_valuemethod that can be implemented by LabelFormatters to verify labels are setup correctly duringsky check(and hopefully insky show-gpustoo, with #2638).Before:
After:
Also updates the docs to highlight that the gpu name needs to be lowercase.
Tested (run the relevant ones):
bash format.shkubectl label nodes <node> skypilot.co/accelerator=A40, try launching/sky check.kubectl label nodes <node> skypilot.co/accelerator=a40(skypilot),kubectl label nodes <node> gpu.nvidia.com/class=A40(coreweave) andkubectl label nodes <node> cloud.google.com/gke-accelerator=nvidia-tesla-a40(gke) on an EKS cluster.sky launch -c test --cloud kubernetes --gpus A40:1andsky launch -c test --cloud kubernetes --gpus a40:1