-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Pin remote dependency for ray job #2659
Conversation
…dantic-on-remote-for-new-provisioner
it seems after this PR, when user install gcp etc locally, pydantic & grpcio etc will not be installed locally directly from the setup. Will this become problematic? |
Those dependencies should be included in the Tested in a clean container that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Pin remote pydantic for ray * remote to be the second requirement * Add remote for k8s yml * format * format
Fixes #2658
ray==2.4.0 does not work without pinning pydantic, which causes the issue for ray job.
Tested (run the relevant ones):
bash format.sh
sky launch -c test --cloud aws --cpus 2 echo hi
in a new containersky launch -c test --cloud gcp --cpus 2 echo hi
in a new containersky launch -c test --cloud azure --cpus 2 echo hi
in a new containerpytest tests/test_smoke.py
pytest tests/test_smoke.py --aws
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh