Fix creation of ~/sky_logging/{timestamp} under dir running sky commands
#2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Oct 5, 2023
sky/backends/cloud_vm_ray_backend.py
Outdated
| @@ -2872,7 +2872,7 @@ def _provision( | |||
| wheel_hash=wheel_hash, | |||
| provision_record=provision_record, | |||
| custom_resource=resources_vars.get('custom_resources'), | |||
| log_dir=self.log_dir) | |||
| log_dir=os.path.expanduser(self.log_dir)) | |||
There was a problem hiding this comment.
How about we add it here instead?
skypilot/sky/provision/logging.py
Line 26 in bc3df3d
jc9123
pushed a commit
to jc9123/skypilot
that referenced
this pull request
Oct 11, 2023
…ommands (skypilot-org#2667) * fix * change position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current master will create a log dir
~/sky_logging/{timestamp}under the dir you runskycommands:This is because of one absent of
os.path.expanduserintroduced by the new provisioner. This PR fixed the bug.Tested (run the relevant ones):
bash format.shsky launch --cloud awsand check there is no extra dirs createdpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh