[Core] Fix the NoOp for rich status #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
changed the title
Michaelvll
changed the title
concretevitamin
approved these changes
Oct 8, 2023
| @@ -15,7 +15,7 @@ class _NoOpConsoleStatus: | |||
| """An empty class for multi-threaded console.status.""" | |||
|
|
|||
| def __enter__(self): | |||
| pass | |||
| return self | |||
There was a problem hiding this comment.
Q: which call path into this caused the original issue?
There was a problem hiding this comment.
The ones like this:
skypilot/sky/provision/provisioner.py
Lines 352 to 353 in f2cf032
The status will be None, when the provisioner is called with sky_logging.is_silent(), which is used for sky spot queue:
Lines 1620 to 1623 in f2cf032
jc9123
pushed a commit
to jc9123/skypilot
that referenced
this pull request
Oct 11, 2023
* Fix the NoOp for rich status * fix shell completion installation * pin pandas * revert dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2665
Previously, when
NoOpis returned,with rich_utils.safe_status() as status:, thestatusis actually the return value of__enter__(None for theNoOp), causing failure ifstatusis used later.Tested (run the relevant ones):
bash format.shspot queue -rfailed to restart spot controller butstartworks #2665.pytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh