New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependency] Fix pandas dependency and dev requirements #2679

Merged

Michaelvll merged 1 commit into master from dependency

Oct 25, 2023

Collaborator

Michaelvll commented Oct 8, 2023

Fixes #2584

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: bash tests/backward_comaptibility_tests.sh


          dependency fix

c299a4f

Michaelvll requested a review from romilbhardwaj

October 8, 2023 22:56

romilbhardwaj approved these changes

View reviewed changes

Collaborator

romilbhardwaj left a comment

Thanks @Michaelvll! I recall pandas 1.3.0 being the lower bound while testing for #2583, so this should be good to go.

Michaelvll merged commit acd5ab7 into master

18 checks passed

Michaelvll deleted the dependency branch

October 25, 2023 22:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment