[Spot] Fix AWS NoCredentialError caused by credential rotation #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
changed the title
…edential-issue-with-aws
…edential-issue-with-aws
There was a problem hiding this comment.
Nice @Michaelvll! Some comments while tests/repro are underway.
Since this touches inner loops, we may need to run AWS smoke tests as well.
| @@ -37,6 +38,11 @@ | |||
|
|
|||
| version = 1 | |||
There was a problem hiding this comment.
Do we need to bump this and/or do the importlib reload hack?
There was a problem hiding this comment.
There is no API changes for this file in the file, so it should be fine not bumping the version.
concretevitamin
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
LGTM @Michaelvll. We should run AWS smoke tests before merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2697
We fixed the cache for
session.resourcein #2675. However, it causes a user using SSO gettingNoCredentialErrorwhen running spot jobs, which might be because of the rotation of the credential used by the cachedsession.resource. We avoid using cachedresource, but create a new one to trigger refresh of the credential.Tested (run the relevant ones):
bash format.shsky spot launch --cloud aws --num-nodes 2 --cpus 2+ sleep 10000000;run with no static credential on spot controller for 11 hours with no issue.pytest tests/test_smoke.py --awspytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh