Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s] Add netcat to dependency checks #2712

Merged
merged 2 commits into from
Oct 16, 2023
Merged

[k8s] Add netcat to dependency checks #2712

merged 2 commits into from
Oct 16, 2023

Conversation

romilbhardwaj
Copy link
Collaborator

Closes #2626. Adds preemptive check for netcat before trying provisioning.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • sky launch -c test --cloud kubernetes on a docker container with a) Neither socat nor nc b) with socat, but without nc c) with all dependencies.
  • Rendered docs locally

Michaelvll
Michaelvll approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this additional check @romilbhardwaj! LGTM.

@romilbhardwaj romilbhardwaj merged commit 09849f8 into master Oct 16, 2023
18 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_nc_dependency branch October 16, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[k8s] Fail to launch cluster on kubernetes within docker container
2 participants
@romilbhardwaj @Michaelvll