[Provisioner] Fix cache for internal file mounts #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suquark
reviewed
Oct 18, 2023
Michaelvll
force-pushed
the
cloud-credential-updates
branch
from
66036c3
to
2101138
Compare
Michaelvll
added a commit
that referenced
this pull request
Oct 29, 2023
* [Provisioner] Fix cache for internal file mounts (#2715) * Fix file mounts * print out the skylet version for better debugging ability * Add skypilot version * 0.4.1 version/commit
Michaelvll
added a commit
that referenced
this pull request
Oct 29, 2023
* [Provisioner] Fix cache for internal file mounts (#2715) * Fix file mounts * print out the skylet version for better debugging ability * Add skypilot version * 0.4.1 version/commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2714
We should not cache the internal file mounts based on the wheel hash, as the cloud credential can be changed, and the cache will cause the credentials on the remote VM failed to udpate.
On master
On the current PR
That said, this change will not affect the performance.
This PR fixes the following reproduction:
sky spot launch --cloud aws echo hiwith only AWS credentials setupsky spot launch --cloud gcp echo hiwith GCP credential setup alreadyTested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh