Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Provisioner] remove stale port code in new provisioner #2716

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Oct 17, 2023

This PR removes some stale code in the current new provisioner implementation.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch --cloud aws --cpus 4 --ports 23783 'python -m http.server 23783' and curl the endpoint
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @cblmemo! Will there be any backward compatibility related issue if a user already created a cluster on AWS with ports opened?

@cblmemo
Copy link
Collaborator Author

cblmemo commented Oct 20, 2023

Good catch @cblmemo! Will there be any backward compatibility related issue if a user already created a cluster on AWS with ports opened?

No, because

  • We clean up ports by just deleting the whole SG in AWS, no matter what ports are specified;
  • At the time the new provisioner PR is merged, there is no ports section in the ray yaml, so config.provider_config.get('ports', []) will always return [] in the deleted code inside this PR.

@cblmemo cblmemo merged commit a6c1375 into master Oct 23, 2023
18 checks passed
@cblmemo cblmemo deleted the provisioner-remove-stale-port-code branch October 23, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants