Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add L4 to accelerator_registry #2724

Merged
merged 2 commits into from
Oct 20, 2023
Merged

[Core] Add L4 to accelerator_registry #2724

merged 2 commits into from
Oct 20, 2023

Conversation

romilbhardwaj
Copy link
Collaborator

Adds L4 to accelerator registry. This allows us to bypass unnecessary calls to service_catalog.list_accelerators every time resource.copy() is called.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Tested sky launch --gpus L4:1

Copy link
Collaborator

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(comment for the future since we're on a time crunch)

Should L8-19 be updated to reflect this? Basically, when to add an accelerator to this list, the consequence of adding / omitting. Better yet if we could do this automatically.

@romilbhardwaj romilbhardwaj merged commit 992a44d into master Oct 20, 2023
18 checks passed
@romilbhardwaj romilbhardwaj deleted the gpus_add_l4 branch October 20, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants