Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Fix ssh proxy command to be null #2756

Merged
merged 5 commits into from
Nov 5, 2023
Merged

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Nov 5, 2023

A user reported that the sky launch fails when the following config.yaml is provided:

aws:
      instance_tags:
          mytag: myvalue
      ssh_proxy_command:
          eu-west-1: null
          us-east-1: null
      use_internal_ips: true
      vpc_name: abc

This is due to our recent schema check for config.yaml in #2645

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test --cloud aws
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Michaelvll.

Copy link
Collaborator

@iojw iojw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@Michaelvll Michaelvll merged commit 2d59e3a into master Nov 5, 2023
18 checks passed
@Michaelvll Michaelvll deleted the fix-ssh-proxy-null branch November 5, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants