Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Handle long node names in GPU Labeler #2795

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Conversation

romilbhardwaj
Copy link
Collaborator

Closes #2752. Job names need to be unique, so we use a 32 len hash of the node name where the labelling job is running.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Tested GPU Labelling on EKS cluster

@romilbhardwaj romilbhardwaj changed the title [k8s] Handle long node names in GPU Labeller [k8s] Handle long node names in GPU Labeler Nov 16, 2023
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@romilbhardwaj romilbhardwaj merged commit 77a32d2 into master Nov 18, 2023
19 checks passed
@romilbhardwaj romilbhardwaj deleted the gpu_labeler_fix branch November 18, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[k8s] GPU labeler may not work with EKS using very long node name
2 participants