Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog] Add trainium accelerator in aws catalog #2798

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Nov 17, 2023

This is to support #2690, adding Trainium in the catalog.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
    • python -m sky.clouds.service_catalog.data_fetchers.fetch_aws
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll changed the title [AWS] Add trainium in aws catalog [Catalog] Add trainium accelerator in aws catalog Nov 17, 2023
@Michaelvll Michaelvll linked an issue Nov 17, 2023 that may be closed by this pull request
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Michaelvll Michaelvll merged commit c6d261f into master Nov 17, 2023
19 checks passed
@Michaelvll Michaelvll deleted the trainium-catalog branch November 17, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated Comments
2 participants