Remove Exponential Backoff for Retry Until Up #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Nov 26, 2023
There was a problem hiding this comment.
Thanks for fixing this @rohanvaidya45! It might be better to remove the exponential backoff only and keep the random jitter.
Michaelvll
reviewed
Nov 26, 2023
sky/backends/cloud_vm_ray_backend.py
Outdated
| @@ -2859,7 +2859,7 @@ def _provision( | |||
| # TODO(suquark): once we have sky on PyPI, we should directly | |||
| # install sky from PyPI. | |||
| local_wheel_path, wheel_hash = wheel_utils.build_sky_wheel() | |||
| backoff = common_utils.Backoff(_RETRY_UNTIL_UP_INIT_GAP_SECONDS) | |||
| jitter = common_utils.Jitter(_RETRY_UNTIL_UP_INIT_GAP_SECONDS) | |||
There was a problem hiding this comment.
Should we just use the Backoff with max_backoff_factor=1?
| @@ -2859,7 +2859,9 @@ def _provision( | |||
| # TODO(suquark): once we have sky on PyPI, we should directly | |||
| # install sky from PyPI. | |||
| local_wheel_path, wheel_hash = wheel_utils.build_sky_wheel() | |||
| backoff = common_utils.Backoff(_RETRY_UNTIL_UP_INIT_GAP_SECONDS) | |||
| backoff = common_utils.Backoff( | |||
There was a problem hiding this comment.
Worth a comment on why we disable exponential backoff. Something like:
The most frequent reason for the failure of a provision request is resource unavailability instead of rate limiting; to make users wait shorter, we do not make the backoffs exponential.
Michaelvll
approved these changes
Nov 28, 2023
Michaelvll
reviewed
Nov 29, 2023
| # limiting; to make users wait shorter, we do not make | ||
| # backoffs exponential. | ||
| backoff = common_utils.Backoff( | ||
| initial_backoff=_RETRY_UNTIL_UP_INIT_GAP_SECONDS, |
There was a problem hiding this comment.
Just tried a few clouds and it seems we can also reduce this _RETRY_UNTIL_UP_INIT_GAP_SECONDS to 30. : )
remyleone
pushed a commit
to remyleone/skypilot
that referenced
this pull request
Dec 26, 2023
* remove exponential backoff * add back random jitter * format * use backoff * format * add comment * rerun checks * format * pylint * form * change to 30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks to resolve #2805
Replaces the use of exponential backoff with the static initial value each retry
Tested:
bash format.shpytest tests/test_smoke.py