Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example] Distributed ray train example #2828

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Nov 29, 2023

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • cd examples/distributed_ray_train; sky launch -c test-ray-train ./ray_train.yaml
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@concretevitamin
Copy link
Collaborator

Shall we add this to "Framework examples" in https://github.com/skypilot-org/skypilot#more-information?

@Michaelvll Michaelvll merged commit a7f185b into master Nov 29, 2023
19 checks passed
@Michaelvll Michaelvll deleted the ray-train-example branch November 29, 2023 22:55
remyleone pushed a commit to remyleone/skypilot that referenced this pull request Dec 26, 2023
* Example for distributed ray train

* rename

* format

* Use torch with cu118

* ray 2.8 works

* Add ray train to readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants