[Spot/Storage] Supports empty spaces in source path for storages #2835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2763 and #2243.
When a source path specified to
file_mounts
in task YAML had an empty space, Skypilot failed to upload thesource
to the cloud storages due to the limitation of CLIs used(#2243). This issue also prevented users from specifyingworkdir
with empty spaces when running managed spot jobs as well sinceworkdir
is uploaded to the cloud storage first(#2763).This PR supports the use of empty spaces in the file/directory names for
source
infile_mounts
andworkdir
for managed spot jobs. And a testtest_upload_source_with_spaces
is added to check such cases.Thanks to @aseriesof-tubes for the contribution.
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py::TestStorageWithCredentials
pytest tests/test_smoke.py::test_gcp_storage_mounts_with_stop --gcp
pytest tests/test_smoke.py::test_aws_storage_mounts_with_stop --aws