[SkyServe] Fix resource parse when multiple accelerators is used #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Dec 13, 2023
There was a problem hiding this comment.
Thanks for the quick fix @cblmemo! Left several quick questions.
| @@ -145,7 +140,7 @@ def _start(service_name: str, tmp_task_yaml: str, job_id: int): | |||
| controller_job_id=job_id, | |||
| policy=service_spec.policy_str(), | |||
| auto_restart=service_spec.auto_restart, | |||
| requested_resources=requested_resources, | |||
There was a problem hiding this comment.
Why can't we still save the requested_resources, which can be a list or set of resources? It might be easier to process the resources information to have a object than a string?
There was a problem hiding this comment.
After an offline discussion, since we still need to store the number of nodes, we decided to keep the current implementation.
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
Michaelvll
added a commit
that referenced
this pull request
Dec 14, 2023
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
Michaelvll
added a commit
that referenced
this pull request
Dec 15, 2023
* Add example for mixtral * update the serve.yaml * install dependencies * remove useless file * simplify port * mixtral official doc * fix model name * Fix setup * Add sky serve up and docs * Use 2 replica instead * Fix typo * Add official doc * fix * fix * nits * Update llm/mixtral/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update llm/mixtral/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update sky/cli.py Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com> * Add method for accessing the models * Address comment * Add optional: * Fix news * Update README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Add skyserve docs link * lint * Fix readme and adopt changes from #2860 * fix mixtral link * fix link --------- Co-authored-by: cblmemo <cblmemo@gmail.com> Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
remyleone
pushed a commit
to remyleone/skypilot
that referenced
this pull request
Dec 26, 2023
…pilot-org#2860) * fix * fix * nits * Update sky/cli.py Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com> * lint * Update sky/serve/serve_utils.py Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com> * comments * print_exception_no_traceback --------- Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
remyleone
pushed a commit
to remyleone/skypilot
that referenced
this pull request
Dec 26, 2023
* Add example for mixtral * update the serve.yaml * install dependencies * remove useless file * simplify port * mixtral official doc * fix model name * Fix setup * Add sky serve up and docs * Use 2 replica instead * Fix typo * Add official doc * fix * fix * nits * Update llm/mixtral/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update llm/mixtral/README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Update sky/cli.py Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com> * Add method for accessing the models * Address comment * Add optional: * Fix news * Update README.md Co-authored-by: Zongheng Yang <zongheng.y@gmail.com> * Add skyserve docs link * lint * Fix readme and adopt changes from skypilot-org#2860 * fix mixtral link * fix link --------- Co-authored-by: cblmemo <cblmemo@gmail.com> Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed the representation of the
request_resourcesfield in service status. Now it will store a string to represent multiple accelerators, just like implementation for SkySpot.Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh