Azure: allow spot instances. #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Dec 15, 2023
| @@ -68,7 +68,6 @@ def get_hourly_cost(instance_type: str, | |||
| region: Optional[str] = None, | |||
| zone: Optional[str] = None) -> float: | |||
| # Ref: https://azure.microsoft.com/en-us/support/legal/offer-details/ | |||
| assert not use_spot, 'Current Azure subscription does not support spot.' | |||
There was a problem hiding this comment.
Do you think we should print a warning or a hint that the spot feature on Azure may not be well tested and let the user to file an issue on GitHub?
There was a problem hiding this comment.
Feels like it should work. Adding may give a sense of being experimental to users. Wdyt?
There was a problem hiding this comment.
Sounds good. Approving this PR for now. Let's wait and see any feedback from users.
Michaelvll
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the artificial restriction that was added due to our subscription not support spot instances. However, users' subscriptions have access so should be allowed.
Tested:
sky launch --cloud azure --use-spot --gpus A100-80GBno longer shows our asserts, but rather proper errors from AzureTested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh