Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: fix spot launch with empty ~/.sky/config.yaml. #2876

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

concretevitamin
Copy link
Collaborator

Fixes 7d8dec2#diff-8acc88bd4d951508e5ea2f822f65dbc0bfaaed24fd6f8c18027affe8fda7ce1fR363.

Tested

sky spot launch  --cloud gcp -y -- echo hi

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@MaoZiming MaoZiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@concretevitamin concretevitamin merged commit ade7f52 into master Dec 16, 2023
19 checks passed
@concretevitamin concretevitamin deleted the fix-spot-launch branch December 16, 2023 16:23
remyleone pushed a commit to remyleone/skypilot that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants