Added LoRAX example for multi-lora LLM inference #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Dec 20, 2023
There was a problem hiding this comment.
Thanks for adding this example @tgaddair! It looks very promising! I am testing out the example right now. Left several nits. Let's get it in as soon as possible. : )
|
Thanks for the review @Michaelvll, addressed your comments. |
Michaelvll
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Thanks for adding the example @tgaddair and the quick fix! I just tested it out and it works like a magic.
Michaelvll
reviewed
Dec 21, 2023
|
Updated the example LoRAs to all use Mistral-7B as a base. Let me know if there's anything else you'd like to address before merging! |
remyleone
pushed a commit
to remyleone/skypilot
that referenced
this pull request
Dec 26, 2023
* Added LoRAX example for multi-lora LLM inference * Width * Move to llm * Updated README * Fix warn * Docker link * Fix ip * Use latest * Addressed comments * Added example LoRAs * Examples * Fixed exampls * Added example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.