Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Install ray dashboard dependencies in CPU k8s image #2884

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

romilbhardwaj
Copy link
Collaborator

Fresh builds of our k8s CPU image would fail during provisioning with:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/sky/.local/lib/python3.10/site-packages/sky/skylet/ray_patches/__init__.py", line 85, in patch
    from ray.dashboard.modules.job import job_head
  File "/home/sky/.local/lib/python3.10/site-packages/ray/dashboard/modules/job/job_head.py", line 9, in <module>
    import aiohttp.web
ModuleNotFoundError: No module named 'aiohttp'

This is because ray dashboard dependencies are not correct installed.

This PR changes ray installation in our Dockerfile to also install dashboard dependencies.

GPU image does not need this change since the base image installs ray[default] anyway.

cc @kbrgl

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @romilbhardwaj!

@romilbhardwaj romilbhardwaj merged commit 1bcc532 into master Dec 19, 2023
19 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_ray_dash_deps branch December 19, 2023 16:49
remyleone pushed a commit to remyleone/skypilot that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants