Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: update multiple resources docs. #2886

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

concretevitamin
Copy link
Collaborator

Users have asked about any_of/ordered fields not found when they installed the v0.4.1 release.

Adds a tip on using nightly.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below): rendered locally
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding @concretevitamin! We should probably keep a note in our internal release guide to remove this tip after our next release

@concretevitamin concretevitamin merged commit 7f5ddbc into master Dec 19, 2023
19 checks passed
@concretevitamin concretevitamin deleted the docs-multi-resources branch December 19, 2023 20:30
@concretevitamin
Copy link
Collaborator Author

Good call, added.

remyleone pushed a commit to remyleone/skypilot that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants