[Provisioner] Fix open ports on Azure #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concretevitamin
approved these changes
Dec 21, 2023
Michaelvll
approved these changes
Dec 22, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug when opening ports in Azure sometimes.
The problem is when SkyPilot created the security group, it didn’t wait for the group to be created; Instead, it just returned and continued to open ports. If the open ports (add security rule) are finished earlier than the security group creation (the creation consists of multiple phases), it might get overridden.
Tested (run the relevant ones):
bash format.shsky launch --cloud azure --ports 8080 --cpus 2 'python -m http.server 8080' --detach-runand curl for 40 clusterspytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namepytest tests/test_smoke.py::test_skyserve_azure_httpbash tests/backward_comaptibility_tests.sh