Docs: update SkyServe docs. #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR #2878 will introduce some changes to the doc |
cblmemo
approved these changes
Dec 23, 2023
| .. tip:: | ||
|
|
||
| Notice that the two replicas are launched in different regions/clouds for the lowest cost and highest GPU availability. | ||
| This is performed automatically, like a regular ``sky launch``. |
There was a problem hiding this comment.
Suggested change
| This is performed automatically, like a regular ``sky launch``. | |
| This is performed automatically on all enabled regions/clouds specified in the task YAML, like a regular ``sky launch``. |
not sure; cloud discuss.
There was a problem hiding this comment.
I think at this point in the tutorial (Quick tour), we haven't said much about the yaml, and we want to be brief here.
Unless you think the current wording is too ambiguous?
There was a problem hiding this comment.
Good point! Let's skip it.
concretevitamin
commented
Dec 23, 2023
| .. tip:: | ||
|
|
||
| Notice that the two replicas are launched in different regions/clouds for the lowest cost and highest GPU availability. | ||
| This is performed automatically, like a regular ``sky launch``. |
There was a problem hiding this comment.
I think at this point in the tutorial (Quick tour), we haven't said much about the yaml, and we want to be brief here.
Unless you think the current wording is too ambiguous?
Sounds good. Hopefully it's minimal merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller_resourcesTested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh