[SkyServe] Support min_replicas = 0
#2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaoZiming
changed the title
min_replicas = 0min_replicas = 0
cblmemo
reviewed
Jan 4, 2024
|
@cblmemo Thanks for the reviews! PTAL |
|
@cblmemo Thanks! Added an example yaml. Checked that a curl will trigger immediate scale up |
cblmemo
reviewed
Jan 5, 2024
cblmemo
reviewed
Jan 6, 2024
Comment on lines
+5
to
+6
| # The endpoint will be printed in the console. | ||
| # Querying the endpoint will trigger a scale up. |
There was a problem hiding this comment.
Add docstr for how to make the replicas to 0, i.e. don;t send any traffic for how many time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #2893
Add a new status
NO_REPLICAS.Lower autoscaler decision interval when
target_num_replicas = 0Tested (run the relevant ones):
bash format.shsky serve up examples/serve/min_replicas_zero.yaml