[GCP] Use storage.admin permission for automatically created skypilot-v1 service account #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concretevitamin
approved these changes
Jan 14, 2024
| @@ -26,7 +26,7 @@ | |||
| # NOTE: `serviceAccountUser` allows the head node to create workers with | |||
| # a serviceAccount. `roleViewer` allows the head node to run bootstrap_gcp. | |||
| DEFAULT_SERVICE_ACCOUNT_ROLES = [ | |||
| 'roles/storage.objectAdmin', | |||
| 'roles/storage.admin', | |||
There was a problem hiding this comment.
The old sky/skylet/providers/gcp/config.py has this too, should it be changed (or should that dir be removed)?
There was a problem hiding this comment.
The dir should be removed now. Also, the AWS node provider should be removed as well #2792. We will handle that in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make sure the service account
skypilot-v1automatically created by skypilot can access the user's bucket, to make it more convenient for the users.Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh