Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SkyServe] Not add default value of {up,down}scale_delay_seconds in service spec #2961

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Jan 9, 2024

Currently, the SkyServiceSpec will add the fields {up,down}scale_delay_seconds even if there are no autoscaling enabled. This PR fixed the issue.

To reproduce:

>>> import sky
>>> sky.serve.SkyServiceSpec.from_yaml_config({'readiness_probe': '/', 'replicas': 1}).to_yaml_config()
{'readiness_probe': {'path': '/', 'initial_delay_seconds': 1200}, 'replica_policy': {'min_replicas': 1, 'upscale_delay_seconds': 300, 'downscale_delay_seconds': 1200}}

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • The reproducible script shown above; now returning
>>> import sky
>>> sky.serve.SkyServiceSpec.from_yaml_config({'readiness_probe': '/', 'replicas': 1}).to_yaml_config()
{'readiness_probe': {'path': '/', 'initial_delay_seconds': 1200}, 'replica_policy': {'min_replicas': 1}}
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@cblmemo cblmemo requested review from Michaelvll and MaoZiming and removed request for Michaelvll January 9, 2024 06:31
Copy link
Collaborator

@MaoZiming MaoZiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
alternatively, we can check whether autoscaler is enabled in service_spec.

@cblmemo cblmemo merged commit 6fd5bf2 into master Jan 10, 2024
19 checks passed
@cblmemo cblmemo deleted the serve-fix-delay-seconds-default-value branch January 10, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants