Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s][docs] Update note in kubernetes docs #2991

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[k8s][docs] Update note in kubernetes docs #2991

merged 1 commit into from
Jan 17, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

image

Tested (run the relevant ones):

  • Docs rendered locally

concretevitamin
concretevitamin approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May want to update the bottom roadmap to check off opening ports too.

@romilbhardwaj
Copy link
Collaborator Author

Thanks!

May want to update the bottom roadmap to check off opening ports too

@hemildesai is working on docs for k8s + ports, will be checked off there :)

@romilbhardwaj romilbhardwaj merged commit 30c0fee into master Jan 17, 2024
19 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_docs_note branch January 17, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romilbhardwaj @concretevitamin