Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for vSphere provider #3000

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

changxiaohui
Copy link
Contributor

Co-authored-by: Yixing Jia yixingjia@gmail.com
Co-authored-by: YongChun Chang changsang91@163.com
Co-authored-by: Shiqi He johnhsq@126.com

Sign-off-by: Yongchun Chang changsang91@163.com

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the docs for vsphere @changxiaohui! Left several comments. We would also like to change the hint in sky check to refer to the docs as well:

            return False, (
                'vSphere dependencies are not installed. '
                'Run the following commands:'
                f'\n{cls._INDENT_PREFIX}  $ pip install skypilot[vSphere]'
                f'\n{cls._INDENT_PREFIX}Credentials may also need to be set. '
                'For more details. See https://skypilot.readthedocs.io/en/latest/getting-started/installation.html#vmware-vsphere'
                f'\n{cls._INDENT_PREFIX}{common_utils.format_exception(e, use_bracket=True)}')

For the place:

return False, (
'vSphere dependencies are not installed. '
'Run the following commands:'
f'\n{cls._INDENT_PREFIX} $ pip install skypilot[vSphere]'
f'\n{cls._INDENT_PREFIX}Credentials may also need to be set. '
f'{common_utils.format_exception(e, use_bracket=True)}')

docs/source/getting-started/installation.rst Outdated Show resolved Hide resolved
docs/source/getting-started/installation.rst Outdated Show resolved Hide resolved
docs/source/getting-started/installation.rst Outdated Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
docs/source/getting-started/installation.rst Outdated Show resolved Hide resolved
@changxiaohui changxiaohui force-pushed the topic/community/doc branch 3 times, most recently from 7fbc6d6 to 33ee835 Compare January 24, 2024 04:00
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the doc @changxiaohui! It looks mostly good to me. It should good to go after the following comments are fixed.

docs/source/getting-started/installation.rst Outdated Show resolved Hide resolved
docs/source/cloud-setup/cloud-permissions/vsphere.rst Outdated Show resolved Hide resolved
docs/source/cloud-setup/cloud-permissions/vsphere.rst Outdated Show resolved Hide resolved
docs/source/cloud-setup/cloud-permissions/vsphere.rst Outdated Show resolved Hide resolved
docs/source/cloud-setup/cloud-permissions/vsphere.rst Outdated Show resolved Hide resolved
docs/source/cloud-setup/cloud-permissions/vsphere.rst Outdated Show resolved Hide resolved
docs/source/cloud-setup/cloud-permissions/vsphere.rst Outdated Show resolved Hide resolved
docs/source/cloud-setup/cloud-permissions/vsphere.rst Outdated Show resolved Hide resolved
Co-authored-by: Yixing Jia yixingjia@gmail.com
Co-authored-by: YongChun Chang changsang91@163.com
Co-authored-by: Shiqi He johnhsq@126.com

Sign-off-by: Yongchun Chang changsang91@163.com
@Michaelvll Michaelvll merged commit 2eff986 into skypilot-org:master Jan 31, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants