Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distributed-jobs.rst to address ulimit issue #3004

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

kishb87
Copy link
Contributor

@kishb87 kishb87 commented Jan 19, 2024

Distributed jobs will result in OSError: [Errno 24] Too many open files unless ulimit is increased. I put a note in the instructions incase others run into this issue.

Distributed jobs will result in `OSError: [Errno 24] Too many open files` unless ulimit is increased. I put a note in the instructions incase others run into this issue.
@kishb87
Copy link
Contributor Author

kishb87 commented Jan 19, 2024

For additional context, you can refer to the Slack thread on this.

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the docs @kishb87! This is awesome. I would prefer to keep the doc a bit simpler. Just left several comments : )

docs/source/running-jobs/distributed-jobs.rst Outdated Show resolved Hide resolved
docs/source/running-jobs/distributed-jobs.rst Outdated Show resolved Hide resolved
docs/source/running-jobs/distributed-jobs.rst Outdated Show resolved Hide resolved
Copy link
Contributor Author

@kishb87 kishb87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Michaelvll
Copy link
Collaborator

LGTM

Thanks for the reply @kishb87! It seems the changes are not committed to this PR. Could you help commit those suggestions in the previous comments? Thanks! : )

Copy link
Contributor Author

@kishb87 kishb87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies I thought it was committed. Will do that now.

@kishb87
Copy link
Contributor Author

kishb87 commented Jan 23, 2024

@Michaelvll - okay should be good now. Let me know if there are any issues.

@Michaelvll Michaelvll merged commit dc347d6 into skypilot-org:master Jan 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants