[LLM] Fix mixtral example for Azure #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
reviewed
Jan 24, 2024
llm/mixtral/serve.yaml
Outdated
| @@ -34,6 +34,9 @@ setup: | | |||
| pip list | grep megablocks || pip install megablocks | |||
|
|
|||
| run: | | |||
| # Remove the default nccl.conf which causes failure on Azure | |||
| sudo mv /etc/nccl.conf /etc/nccl.conf.bak || true | |||
There was a problem hiding this comment.
What is this file for? Will this have any side-effects?
There was a problem hiding this comment.
Also is it a common issue for other workloads? Should we add it in azure-ray.yml.j2 instead?
There was a problem hiding this comment.
This is a good point! This file is wrongly configured on Azure with multiple GPUs, causing the issue with the distributed workload using nccl. We should include this in the azure-ray.yml.j2.
Michaelvll
force-pushed
the
fix-mixtral-example-for-azure
branch
from
c24169d
to
79ea123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2905
Fix mixtral example for Azure by removing the problemetic nccl config file on Azure.
With this PR, after #2434 is merged, we should be able to change the examples to
disk_tier: best, so that Azure is allowed to be part of the candidates.Tested (run the relevant ones):
bash format.shsky launch --disk-tier none -c test-mixtral --cloud azure llm/mixtral/serve.yamlsky launch -c test-gcp-mixtral --cloud gcp --use-spot llm/mixtral/serve.yamlpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh