Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Make the IP fetch more robust #3025

Merged
merged 4 commits into from
Jan 30, 2024
Merged

[Core] Make the IP fetch more robust #3025

merged 4 commits into from
Jan 30, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Jan 25, 2024 •
edited

Errors during fetching IP should correctly raise an error, which is important for sky down.

Fixes #3029

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll marked this pull request as ready for review January 26, 2024 19:09
@Michaelvll Michaelvll merged commit ef21192 into master Jan 30, 2024
19 checks passed
@Michaelvll Michaelvll deleted the make-ip-fetch-robust branch January 30, 2024 06:50
@Michaelvll
Copy link
Collaborator Author

This also fixes the issue when the cluster is partially UP for k8s cluster, and call sky down on that cluster may cause cpu_request to be None in the get_cluster_info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblmemo cblmemo cblmemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Runpod] Tearing down Runpod deployment before UP throws IP error
2 participants
@Michaelvll @cblmemo