New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] Ignore missing gcp credentials #3028

Merged

Michaelvll merged 1 commit into master from remove-gcp-legacy-credential

Jan 25, 2024

Collaborator

Michaelvll commented Jan 25, 2024 •

edited

Fixes #3026

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
- sky launch -c test --cloud gcp --cpus 2 with legacy_credentials removed.
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: bash tests/backward_comaptibility_tests.sh


          ignore missing gcp credentials

38ca468

Michaelvll marked this pull request as ready for review

January 25, 2024 18:07

Michaelvll requested a review from concretevitamin

January 25, 2024 18:08

concretevitamin approved these changes

View reviewed changes

Michaelvll merged commit 16cdc7f into master

19 checks passed

Michaelvll deleted the remove-gcp-legacy-credential branch

January 25, 2024 18:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment